-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type error on picker prop #677
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -99,7 +99,7 @@ export type PickerPanelBaseProps<DateType> = { | |||
} & PickerPanelSharedProps<DateType>; | |||
|
|||
export type PickerPanelDateProps<DateType> = { | |||
picker?: 'date'; | |||
picker?: 'time' | 'date' | 'week' | 'month' | 'year'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type PickerPanelDateProps
is works for date
only.
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 56 56
Lines 2443 2443
Branches 734 728 -6
=======================================
Hits 2417 2417
Misses 24 24
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Conflicting |
When passing picker prop that is not
' date' | undefined
It throws a TS error even though other props are accepted by the component such as "month" or "year".